main: remove symlink #679
Merged
main: remove symlink #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! Let's keep in in for backwards-compatibility (it's mentioned in a lot of docs across the ecosystem), and it's also nicer from a product perspective: |
metachris
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #678
During the last refactor I added a symlink from main.go -> cmd/mev-boost/main.go
Seems like go install has an issue when working with symlinks
Alternatively, since we already broke users, we could just get rid of the symlink and force everyone to
go install github.com/flashbots/mev-boost/cmd/mev-boost@latest