Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.7 version release #621

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Add 1.7 version release #621

merged 2 commits into from
Feb 27, 2024

Conversation

avalonche
Copy link
Collaborator

πŸ“ Summary

Adding the v1.7 release version in the builder version.

β›± Motivation and Context

Preparing for #605. Testing on shadow fork was successful and no issues were found.

πŸ“š References


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 52.52%. Comparing base (3a8bcb9) to head (4b9fd4b).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #621       +/-   ##
============================================
- Coverage    68.07%   52.52%   -15.55%     
============================================
  Files            7       14        +7     
  Lines         1206     1601      +395     
============================================
+ Hits           821      841       +20     
- Misses         331      703      +372     
- Partials        54       57        +3     
Flag Coverage Ξ”
unittests 52.52% <ΓΈ> (-15.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@avalonche avalonche force-pushed the release/v1.7 branch 5 times, most recently from 39bb78c to 072d9ec Compare February 27, 2024 04:44
@@ -17,7 +17,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: ^1.20
go-version: ^1.21.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might as well update to go 1.22

@metachris
Copy link
Collaborator

it would be better to separate the go upgrade from the release / version bump

otherwise, instead of updating to Go 1.21 you can use latest Go v1.22

@metachris metachris merged commit 352a7b2 into develop Feb 27, 2024
10 checks passed
@metachris metachris deleted the release/v1.7 branch February 27, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants