sbundle stats endpoint #557
Conversation
TymKh
requested review from
odysseus0,
sketsdever,
zeroXbrock and
sukoneck
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -768,6 +768,76 @@ where | |||
| - `consideredByBuildersAt`: indicates time at which each builder selected the bundle to be included in the target block | |||
| - `sealedByBuildersAt`: indicates time at which each builder sealed a block containing the bundle | |||
|
|
|||
| ### flashbots_getSbundleStats | |||
|
|
|||
| The `flashbots_getSbundleStats` JSON-RPC method returns stats for a single sbundle. You must provide bundleHash, and the signing address must be the same as the one who submitted the bundle. | |||
There was a problem hiding this comment.
- Can we define what "sbundle" means? Or link to an existing description?
- Nit: Format "bundleHash" as code (ie. using the slash quotes like:
bundleHash)
| ### flashbots_getSbundleStats | ||
|
|
||
| The `flashbots_getSbundleStats` JSON-RPC method returns stats for a single sbundle. You must provide bundleHash, and the signing address must be the same as the one who submitted the bundle. | ||
| Only bundles not containing backruns are supported |
There was a problem hiding this comment.
Might not be immediately clear what we mean by this. Could clarify a bit: sbundle stats are only visible for bundles that do contain other users' private transactions. Ie. you cannot view sbundle stats on a bundle which backruns another user in MEV-Share.
(Feel free to reword, I just think it might need a bit more explanation).
|
|
||
| Only responds with success when sbundle is already simulated. | ||
|
|
||
| When relay has simulated the bundle but the target block (or maxBlock) has not been reached: |
There was a problem hiding this comment.
Nit: specify "the bundle relay" so we don't confuse with MEV-Boost relay.
| "method": "flashbots_getSbundleStats", | ||
| "params": [ | ||
| { | ||
| bundleHash, // String, returned by the flashbots api when calling eth_sendBundle with builders field or mev_sendBundle |
There was a problem hiding this comment.
Is this returned in addition to or instead of the smart field? Currently our docs say that a smart field is returned when calling eth_sendBundle with builders[]
There was a problem hiding this comment.
Yes it is returned together with eth_sendBundle response or else it will be hard for searcher to use stats api. So eth_sendBundle api is backward compatible, bundleHash is always returned, in case smart:true returned, searcher should query this endpoint.
No description provided.