Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prettier formatting for docs #187

Closed
wants to merge 4 commits into from

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Apr 2, 2021

@askvortsov1
Copy link
Member

Let's wait to merge this until we get #178 in

@davwheat
Copy link
Member Author

davwheat commented Apr 2, 2021

@askvortsov1 What's preventing that being merged at the moment, out of curiousity?

@askvortsov1
Copy link
Member

askvortsov1 commented Apr 2, 2021

@askvortsov1 What's preventing that being merged at the moment, out of curiousity?

I keep forgetting to leave a review 🙈

Brings this repo in line with other core repos
@dsevillamartin
Copy link
Member

dsevillamartin commented May 3, 2021

I don't like how the PHP codeblocks are being formatted...
It also sets the PHP code indentation to 2 spaces instead of the current 4 we have.
image

@askvortsov1
Copy link
Member

Agreed, can we keep the 4 spaces?

@askvortsov1
Copy link
Member

@davwheat After #374 and #334 are merged (or closed), could we rebase this and adjust for Docusaurus? We'll also only want to apply prettier to the English docs, since translations will be managed via crowdin.

@littlegolden
Copy link
Contributor

littlegolden commented Oct 6, 2021

@davwheat After #374 and #334 are merged (or closed), could we rebase this and adjust for Docusaurus? We'll also only want to apply prettier to the English docs, since translations will be managed via crowdin.

#374 closed, can't wait for the Docusaurus 😃

@askvortsov1
Copy link
Member

@davwheat After #374 and #334 are merged (or closed), could we rebase this and adjust for Docusaurus? We'll also only want to apply prettier to the English docs, since translations will be managed via crowdin.

#374 closed, can't wait for the Docusaurus 😃

We're already on Docusaurus (docs.flarum.org), which is why there were a bunch of merge conflicts in that PR. It should make translations easier to maintain (crowdin provides a GUI, plus you dont need sidebars for each language, and the file organization is a lot neater, and a few other things).

@davwheat davwheat closed this Nov 21, 2021
@davwheat davwheat deleted the add-prettier branch November 21, 2021 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants