Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some outdated explanations in docker README #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jo4965
Copy link

@jo4965 jo4965 commented Oct 25, 2023

Hello. I'm dmjo who loves Flare.
I really appreciate for developing such a nice node system.

I'm operating some of Flare observers now with dockerization
and found some mismatch between real operation and the docker README.

What is the problem?

  1. Mismatch between README and Dockerfile
    • The README-docker.md file reads that both AUTOCONFIGURE_PUBLIC_IP and AUTOCONFIGURE_BOOTSTRAP is set to '0' as default.
    • Dockerfile, however, configures them as '1' when initializing.
    • Below is part of current Dockerfile which set them to '1'

ENV HTTP_HOST=0.0.0.0 \
    HTTP_PORT=9650 \
    STAKING_PORT=9651 \
    PUBLIC_IP= \
    DB_DIR=/app/db \
    DB_TYPE=leveldb \
    BOOTSTRAP_IPS= \
    BOOTSTRAP_IDS= \
    CHAIN_CONFIG_DIR=/app/conf \
    LOG_DIR=/app/logs \
    LOG_LEVEL=info \
    NETWORK_ID=costwo \
    AUTOCONFIGURE_PUBLIC_IP=1 \
    AUTOCONFIGURE_BOOTSTRAP=1 \
    AUTOCONFIGURE_BOOTSTRAP_ENDPOINT=https://coston2.flare.network/ext/info \
    EXTRA_ARGUMENTS="" \
    BOOTSTRAP_BEACON_CONNECTION_TIMEOUT="1m"
  • I think this should be fixed in the way like this PR or the other way (set to '0' in Dockerfile).
  1. Some explanations in configuration are outdated.
    • Coreth v0.8.14 deprecated some of the configuration flags for eth_apis containing public- and private-.
    • AFAIK, the latest version of go-flare is now using Coreth v0.8.16 so the configurations should be changed.
    • You can find the information in the link and the picture I attached below
image

@aljazs-flare
Copy link
Contributor

Thank you for finding and reporting these issues. Will need review from someone else from the team to verify those Coreth options as I'd say I'm not familiar enough with it.
Other than that looks just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants