Skip to content

Commit

Permalink
fix: change hostnameOverride to domain
Browse files Browse the repository at this point in the history
  • Loading branch information
Vibhor Dabas committed Jul 24, 2023
1 parent dc0e17f commit 3d94315
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 13 deletions.
8 changes: 3 additions & 5 deletions chart/templates/ingress.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
{{- if .Values.hostnameOverride -}}
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
Expand All @@ -8,10 +7,10 @@ metadata:
kubernetes.io/tls-acme: "true"
spec:
tls:
- hosts: {{ .Values.hostnameOverride | quote }}
- hosts: {{ .Values.domain | quote }}
secretName: mission-control-tls-{{ .Release.Name }}
rules:
- host: {{ .Values.hostnameOverride | quote }}
- host: {{ .Values.domain | quote }}
http:
paths:
- path: /
Expand All @@ -20,5 +19,4 @@ spec:
service:
name: incident-manager-ui-x-default-x-{{ .Release.Name }}
port:
number: 80
{{- end }}
number: 80
9 changes: 1 addition & 8 deletions chart/values.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
nameOverride: ""
fullnameOverride: ""
hostnameOverride: ""
domain: ""
missionControlChartVersion: ">=0.0.0"
missionControl:
canary-checker:
Expand All @@ -11,13 +11,6 @@ missionControl:
oryKratosURL: https://mission-control.local/api/.ory
ingress:
enabled: false
# annotations:
# kubernetes.io/tls-acme: "true"
# host: mission-control.local
# tls:
# - hosts:
# - mission-control.demo.local
# secretName: mission-control-tls

# See https://github.com/loft-sh/vcluster/blob/main/charts/k3s/values.yaml
vcluster:
Expand Down

0 comments on commit 3d94315

Please sign in to comment.