refactor: extract playbook spec form from modal #2385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This will allow us to add connection form # Conflicts: # src/components/Playbooks/Settings/PlaybookSpecCard.tsx
Fixes #2246 chore: enable hiding resource column fix: make minor adjustments to resource display
Fixes #2246 fix: fix minor issues related to the permissions tab fix: fix failing tests and hard delete permissions fix: don't allow deleting of crd source permissions fix: fix failing test feat: add form for adding permissions in resource and fix form issues Fixes #2246 fix: fix failing build due to removed search layout component
fix: fix failing tests
chore: make improvements to permissions Update src/components/Permissions/ManagePermissions/Forms/PermissionForm.tsx Co-authored-by: Moshe Immerman <[email protected]> Update src/components/Permissions/ManagePermissions/Forms/FormikPermissionSelectResourceFields.tsx Co-authored-by: Moshe Immerman <[email protected]> Update src/components/Permissions/ManagePermissions/Forms/DeletePermission.tsx Co-authored-by: Moshe Immerman <[email protected]> Update src/components/Permissions/ManagePermissions/Forms/FormikPermissionSelectResourceFields.tsx Co-authored-by: Moshe Immerman <[email protected]> Update src/components/Permissions/ManagePermissions/Forms/FormikPermissionSelectResourceFields.tsx Co-authored-by: Moshe Immerman <[email protected]> Update src/components/Permissions/ManagePermissions/Forms/PermissionForm.tsx Co-authored-by: Moshe Immerman <[email protected]>
Update src/components/Connections/ConnectionFormModal.tsx Co-authored-by: Moshe Immerman <[email protected]>
moshloop
force-pushed
the
permissions2
branch
from
22c6291
to
35e0b32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to add connection form