Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2174-Merge-topology-and-catalog-pages #2216

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mainawycliffe
Copy link
Contributor

@mainawycliffe mainawycliffe commented Aug 23, 2024

Fixes #2174

Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
aws-preview ✅ Ready (Inspect) Visit Preview Oct 31, 2024 7:00am
flanksource-ui ✅ Ready (Inspect) Visit Preview Oct 31, 2024 7:00am

Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for flanksource-demo-stable ready!

Name Link
🔨 Latest commit c0bcc50
🔍 Latest deploy log https://app.netlify.com/sites/flanksource-demo-stable/deploys/672328effddb000008912d0e
😎 Deploy Preview https://deploy-preview-2216--flanksource-demo-stable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for goofy-euclid-75956c ready!

Name Link
🔨 Latest commit c0bcc50
🔍 Latest deploy log https://app.netlify.com/sites/goofy-euclid-75956c/deploys/672328eff3ca740008a63097
😎 Deploy Preview https://deploy-preview-2216--goofy-euclid-75956c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for clerk-saas-ui ready!

Name Link
🔨 Latest commit c0bcc50
🔍 Latest deploy log https://app.netlify.com/sites/clerk-saas-ui/deploys/672328efe92c1900089fc3ee
😎 Deploy Preview https://deploy-preview-2216--clerk-saas-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@moshloop
Copy link
Member

@mainawycliffe Can we extract the topology card changes to their own card ?

@mainawycliffe mainawycliffe force-pushed the 2174-Merge-topology-and-catalog-pages branch from 793e7ea to 9d67972 Compare August 28, 2024 16:22
@mainawycliffe mainawycliffe force-pushed the 2174-Merge-topology-and-catalog-pages branch 2 times, most recently from 3e9d682 to 6412da4 Compare August 29, 2024 16:10
@mainawycliffe mainawycliffe force-pushed the 2174-Merge-topology-and-catalog-pages branch from 6412da4 to 8cd5616 Compare August 30, 2024 06:10
@mainawycliffe mainawycliffe marked this pull request as ready for review August 30, 2024 06:10
@mainawycliffe mainawycliffe force-pushed the 2174-Merge-topology-and-catalog-pages branch from 8cd5616 to 2091624 Compare August 30, 2024 07:35
@mainawycliffe mainawycliffe marked this pull request as draft August 30, 2024 07:35
@mainawycliffe mainawycliffe force-pushed the 2174-Merge-topology-and-catalog-pages branch from 2091624 to a1b720e Compare August 30, 2024 12:08
@mainawycliffe mainawycliffe force-pushed the 2174-Merge-topology-and-catalog-pages branch from a1b720e to d606221 Compare September 17, 2024 17:32
@moshloop
Copy link
Member

moshloop commented Oct 21, 2024

@mainawycliffe

  • Can we use a splitter in between? https://github.com/johnwalley/allotment
  • the headline properties should render exactly the same at the very top of the panel,
  • There is a double tooltip on the metrics, and the bar should be left aligned
Screenshot 2024-10-21 at 10 23 51

Fixes #2174

fix: show loading animation, until card is shown or not

chore: wip

fix: fix incorrect import

fix: change how merged pages work

fix: fix issue from pr review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge topology and catalog pages
2 participants