Formik modal #2034
Formik modal #2034
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for clerk-saas-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for goofy-euclid-75956c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for flanksource-demo-stable ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@moshloop initialValues can only be set once in formik, before initialization, not after, when the form is loaded, you would need to update values, which you can do with the FormikContext, which you can setFieldValues, with the fields you need to update. I think we need to try and not deviate from this standard usage, which is already established, as long as the child component is inside a Formik form, it has access to the FormikContext and can be used to manipulate form values. |
| onSuccess: () => void; | ||
| selectedOption: CreateIntegrationOption; | ||
| selectedOption: IntegrationOption; | ||
| onBack: () => void; |
There was a problem hiding this comment.
Probably need to remove this onBack duplicate
src/ui/Modal/FormikModal.tsx
Outdated
| import HelpLink from "../Buttons/HelpLink"; | ||
|
|
||
| interface FormikModalProps extends IModalProps { | ||
| initialValues?: Record<string, any>; |
There was a problem hiding this comment.
This in context will be ineffective, as initial value an only be set on initial render, and the children will have access to all formik controls, to update the values, so they can update the values directly instead, if they need to.
mainawycliffe
force-pushed
the
formik-modal
branch
from
1ea0177
to
7f245e1
Compare
chore: improve integration wizard
chore: improve modal fix: fix type issues
mainawycliffe
force-pushed
the
formik-modal
branch
from
7f245e1
to
127dba3
Compare
Goals: