fix: fix filter by health and status not working

Fixes #2364
flanksource · Oct 22, 2024 · d46e745 · d46e745
1 parent be7719b
commit d46e745
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/src/api/query-hooks/index.ts b/src/api/query-hooks/index.ts
@@ -1,4 +1,4 @@
-import { tristateOutputToQueryFilterParam } from "@flanksource-ui/ui/Dropdowns/TristateReactSelect";
+import { setTristateOutputToQueryFilterToURLSearchParam } from "@flanksource-ui/ui/Dropdowns/TristateReactSelect";
 import { UseQueryOptions, useQuery } from "@tanstack/react-query";
 import { isNull } from "lodash";
 import { toastError } from "../../components/Toast/toast";
@@ -193,13 +193,11 @@ export function prepareConfigListQuery({
   }
 
   if (status && status !== "All") {
-    const statusParam = tristateOutputToQueryFilterParam(status, "status");
-    query.append("status", statusParam);
+    setTristateOutputToQueryFilterToURLSearchParam(query, status, "status");
   }
 
   if (health) {
-    const healthParam = tristateOutputToQueryFilterParam(health, "health");
-    query.append("health", healthParam);
+    setTristateOutputToQueryFilterToURLSearchParam(query, health, "health");
   }
 
   if (search) {

diff --git a/src/ui/Dropdowns/TristateReactSelect.tsx b/src/ui/Dropdowns/TristateReactSelect.tsx
@@ -83,6 +83,20 @@ export function tristateOutputToQueryFilterParam(
   return `&${key}.filter=${paramValue}`;
 }
 
+export function setTristateOutputToQueryFilterToURLSearchParam(
+  searchParams: URLSearchParams,
+  param: string | undefined,
+  key: string
+) {
+  if (param === undefined) {
+    return "";
+  }
+  const paramValue = tristateOutputToQueryParamValue(param);
+  if (paramValue) {
+    searchParams.set(`${key}.filter`, paramValue);
+  }
+}
+
 type TriStateToggleState = {
   [key: string]: number;
 };