fix: Config changes - reset page to 1 when filters change

Fixes #2007
flanksource · Jun 6, 2024 · 97e9acb · 97e9acb
1 parent d6eae7b
commit 97e9acb
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/components/Configs/Insights/Filters/ConfigInsightsFilters.tsx b/src/components/Configs/Insights/Filters/ConfigInsightsFilters.tsx
@@ -10,7 +10,7 @@ type ConfigInsightsFiltersProps = {
 };
 
 export function ConfigInsightsFilters({
-  paramsToReset = ["pageIndex", "pageSize"]
+  paramsToReset = ["pageIndex"]
 }: ConfigInsightsFiltersProps) {
   return (
     <FormikFilterForm

diff --git a/src/pages/config/ConfigChangesPage.tsx b/src/pages/config/ConfigChangesPage.tsx
@@ -187,7 +187,7 @@ export function ConfigChangesPage() {
           ) : (
             <>
               <ConfigChangeFilters
-                paramsToReset={["pageIndex", "pageSize"]}
+                paramsToReset={["page"]}
                 arbitraryFilters={arbitraryFilter}
               />
               <ConfigChangeHistory

diff --git a/src/pages/config/ConfigInsightsList.tsx b/src/pages/config/ConfigInsightsList.tsx
@@ -59,7 +59,7 @@ export function ConfigInsightsPage() {
       >
         <ConfigPageTabs activeTab="Insights">
           <div className="flex flex-row items-center">
-            <ConfigInsightsFilters paramsToReset={["pageIndex", "pageSize"]} />
+            <ConfigInsightsFilters paramsToReset={["pageIndex"]} />
           </div>
           <div className="flex flex-col h-full overflow-y-hidden">
             <ConfigInsightsList

diff --git a/src/pages/config/details/ConfigDetailsChangesPage.tsx b/src/pages/config/details/ConfigDetailsChangesPage.tsx
@@ -131,7 +131,7 @@ export function ConfigDetailsChangesPage() {
     >
       <div className={`flex flex-col flex-1 h-full overflow-y-auto`}>
         <div className="flex flex-col flex-1 items-start gap-2 overflow-y-auto">
-          <ConfigRelatedChangesFilters />
+          <ConfigRelatedChangesFilters paramsToReset={["page"]} />
           <div className="flex flex-col flex-1 overflow-y-auto">
             <ConfigChangeHistory
               linkConfig={!hideConfigColumn}