fix: fix page size not being set and loading not being shown

flanksource · Oct 22, 2024 · 2a22ce0 · 2a22ce0
1 parent c8d1724
commit 2a22ce0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/api/services/configs.ts b/src/api/services/configs.ts
@@ -289,10 +289,14 @@ export async function getConfigsChanges({
   if (severity) {
     requestData.set("severity", severity);
   }
-  if (pageIndex && pageSize) {
+  if (pageIndex) {
     requestData.set("page", parseInt(pageIndex.toString()) + 1);
+  }
+
+  if (pageSize) {
     requestData.set("page_size", pageSize);
   }
+
   if (sortBy) {
     // for descending order, we need to add a "-" before the sortBy field
     requestData.set("sort_by", `${sortOrder === "desc" ? "-" : ""}${sortBy}`);

diff --git a/src/pages/config/ConfigChangesPage.tsx b/src/pages/config/ConfigChangesPage.tsx
@@ -101,7 +101,7 @@ export function ConfigChangesPage() {
               <ConfigChangeFilters paramsToReset={["page"]} />
               <ConfigChangeTable
                 data={changes}
-                isLoading={isLoading}
+                isLoading={isLoading || isRefetching}
                 totalRecords={totalChanges}
                 numberOfPages={totalChangesPages}
               />