fix: fix filter form syncing issues from url

flanksource · Jun 6, 2024 · 2167f19 · 2167f19
1 parent b1f8e78
commit 2167f19
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/src/components/Forms/FormikFilterForm.tsx b/src/components/Forms/FormikFilterForm.tsx
@@ -31,23 +31,17 @@ function FormikChangesListener({
     paramsToReset.forEach((param) => searchParams.delete(param));
     setSearchParams(searchParams);
     // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [values]);
+  }, [values, setFieldValue]);
 
   // reset form values, if the query params change
   useEffect(() => {
     filterFields.forEach((field) => {
       const value = searchParams.get(field);
       const defaultValue = defaultFieldValues?.[field] ?? undefined;
-      if (!value) {
-        if (defaultValue) {
-          setFieldValue(field, defaultValue);
-        } else {
-          setFieldValue(field, undefined);
-        }
-      }
+      setFieldValue(field, value ?? defaultValue);
     }, []);
     // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [searchParams]);
+  }, [defaultFieldValues, filterFields, searchParams]);
 
   // eslint-disable-next-line react/jsx-no-useless-fragment
   return <>{children}</>;