-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: playbook parameter docs #291
Conversation
✅ Deploy Preview for flanksource-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for canarychecker canceled.
|
Can we add snippet examples for each of the param types? And maybe use a kitchen sink example with all options: |
8db3324
to
d7e464e
Compare
@adityathebe - Can you also check any vale lint errors ? We probably need to force value to exit on error, and only run it on changed files with something like: https://github.com/marketplace/actions/changed-files |
a10faf3
to
968627b
Compare
@moshloop added vale checks on changed files. Added few more words on the ignore list and sorted it. |
968627b
to
820248d
Compare
resolves: #224
not sure exactly what #224 was pointing to but I have made some improvements.