Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude deleted when looking up by external id #745

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

adityathebe
Copy link
Member

@adityathebe adityathebe commented Jul 12, 2024

We have two helm releases with the same name on the same namespace but different ids.
The deleted one is being fetched currently when setting up the parent.

@adityathebe adityathebe requested a review from moshloop July 12, 2024 14:17
@adityathebe adityathebe enabled auto-merge (rebase) July 12, 2024 14:18
@adityathebe adityathebe force-pushed the fix/external-id-lookup branch from 0fc6b06 to a2902ef Compare July 12, 2024 14:29
@adityathebe adityathebe force-pushed the fix/external-id-lookup branch from a2902ef to 9855f39 Compare July 12, 2024 14:31
@adityathebe adityathebe merged commit fc10fe2 into main Jul 12, 2024
7 checks passed
@adityathebe adityathebe deleted the fix/external-id-lookup branch July 12, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant