fix: updating creation & deletion timestamps #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* for configs with no creation timestamp (example: Kubernetes cluster), we were always updating the created_at field. More so, the field was set to zero value. * for configs that weren't deleted, we were always updating the deleted_at field to a NULL value. Now, we only set to NULL if the existing config was actually deleted before. This fixes the accuracy of the updated rows counter.
adityathebe
force-pushed
the
fix/scrape-summary
branch
from
ef412aa to
6ba4e2b
Compare
|
🎉 This PR is included in version 0.0.378 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for configs with no creation timestamp (example: Kubernetes cluster), we were always updating the created_at field. More so, the field was set to zero value.
for configs that weren't deleted, we were always updating the deleted_at field to a NULL value. Now, we only set to NULL if the existing config was actually deleted before.
This fixes the accuracy of the updated rows counter.
resolves: #707