Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Helm direct parent #671

Merged
merged 1 commit into from
Jun 26, 2024
Merged

feat: Helm direct parent #671

merged 1 commit into from
Jun 26, 2024

Conversation

adityathebe
Copy link
Member

resolves: #668

@@ -730,10 +730,6 @@ func extractConfigsAndChangesFromResults(ctx api.ScrapeContext, scrapeStartTime

func setConfigParents(ctx api.ScrapeContext, parentTypeToConfigMap map[configExternalKey]string, allConfigs []*models.ConfigItem) error {
for _, ci := range allConfigs {
if ci.ParentID != nil {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this as it'll prevent updating the parents of existing item.

@moshloop moshloop merged commit aa5c992 into main Jun 26, 2024
7 checks passed
@moshloop moshloop deleted the feat/helm-and-argo-parents branch June 26, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make HelmRelease / Argo App a hard parent
2 participants