Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: whitespace in kubernetes exclusions #670

Closed
wants to merge 1 commit into from

Conversation

adityathebe
Copy link
Member

resolves: #667

@@ -811,3 +811,14 @@ func parseAzureURI(uri string) (string, string) {

return subscriptionID, vmScaleSetID
}

func splitTrimmed(input, cut string) []string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this go into MatchItems ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought of that initially but then you would lose the ability to actually match space.

@adityathebe adityathebe deleted the fix/white-space-kubernetes-exclusion branch October 18, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle whitespaces in ignore-changes annotation
2 participants