Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: paths for availability zone & zone ID in aws scraper #596

Merged
merged 2 commits into from
May 30, 2024

Conversation

adityathebe
Copy link
Member

@adityathebe adityathebe commented May 29, 2024

resolves: #577

We use a virtual root to deal with graphs with multiple parent-less items.

Fixes:

  • no need to manually define what config item is the root
  • can handle result set with multiple roots (example: results from aws scraper where the account config & all the configs for the aws regions are root)
  • parent of availability zone id

@adityathebe adityathebe force-pushed the fix/aws-scraper-availability-zone-paths branch 2 times, most recently from 27b939b to b9d7575 Compare May 29, 2024 06:26
@adityathebe adityathebe requested a review from moshloop May 29, 2024 06:28
db/update.go Outdated Show resolved Hide resolved
@adityathebe adityathebe force-pushed the fix/aws-scraper-availability-zone-paths branch 3 times, most recently from 5059b97 to d1f5b8b Compare May 29, 2024 15:13
@adityathebe adityathebe force-pushed the fix/aws-scraper-availability-zone-paths branch from d1f5b8b to 0d1526c Compare May 29, 2024 15:15
@adityathebe adityathebe requested a review from moshloop May 29, 2024 15:18
@moshloop moshloop merged commit 7174aea into main May 30, 2024
7 checks passed
@moshloop moshloop deleted the fix/aws-scraper-availability-zone-paths branch May 30, 2024 06:10
Copy link

🎉 This PR is included in version 0.0.309 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws scraper graph
2 participants