chore: convert policy doc to json #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmehrotra
force-pushed
the
assume-policy-doc-json
branch
from
eba5164 to
d606328
Compare
yashmehrotra
commented
May 23, 2024
Comment on lines
+1078
to
+1085
| var profileRoles []map[string]any | ||
| for _, r := range profileMap["Roles"].([]any) { | ||
| profileRoles = append(profileRoles, r.(map[string]any)) | ||
| } | ||
| profileMap["Roles"] = profileRoles | ||
|
|
||
| for _, role := range profileMap["Roles"].([]map[string]any) { | ||
| if val, exists := role["AssumeRolePolicyDocument"]; exists { |
There was a problem hiding this comment.
@moshloop @adityathebe Is there a better way to do this ?
for _, role := range profileMap["Roles"].([]map[string]any) {
will not work directly as it of type []any
yashmehrotra
force-pushed
the
assume-policy-doc-json
branch
from
d606328 to
3b1cd6b
Compare
|
🎉 This PR is included in version 0.0.299 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #126