Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont error out on duplicate edge insertion #564

Merged
merged 1 commit into from
May 20, 2024

Conversation

adityathebe
Copy link
Member

@adityathebe adityathebe commented May 20, 2024

when forming partial graphs we'll often try to insert duplicate edges. It's safe to ignore that error.

Example: when we fetch two deployment parents after receiving two different pods in a batch of event, we try to add edges from the paths in the deployment.

Deploy A path: Cluster.Namespace.DA
Deploy B path: Cluster.Namespace.DB

Cluster->Namespace edge is then attempted to add twice.

@adityathebe adityathebe requested a review from moshloop May 20, 2024 12:35
@moshloop moshloop merged commit 5d5b545 into main May 20, 2024
7 checks passed
@moshloop moshloop deleted the fix/duplicate-graph-edges branch May 20, 2024 12:59
Copy link

🎉 This PR is included in version 0.0.286 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants