Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle deletion of configs #560

Merged
merged 2 commits into from
May 20, 2024
Merged

fix: handle deletion of configs #560

merged 2 commits into from
May 20, 2024

Conversation

adityathebe
Copy link
Member

@adityathebe adityathebe commented May 20, 2024

resolves: #559

When a pod of a job is deleted, an event isn't created. We need to delete the pod based in the watch event type.

@adityathebe adityathebe requested a review from moshloop May 20, 2024 05:47
@adityathebe adityathebe force-pushed the fix/handle-deletes branch from d8b3008 to 6864e87 Compare May 20, 2024 11:33
@moshloop moshloop merged commit c2e9b00 into main May 20, 2024
7 checks passed
@moshloop moshloop deleted the fix/handle-deletes branch May 20, 2024 13:01
Copy link

🎉 This PR is included in version 0.0.287 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deletion of pods created by jobs aren't tracked properly
2 participants