Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parent & path of configs & batch saving #539

Merged
merged 4 commits into from
May 13, 2024
Merged

fix: parent & path of configs & batch saving #539

merged 4 commits into from
May 13, 2024

Conversation

adityathebe
Copy link
Member

@adityathebe adityathebe commented May 12, 2024 •
edited
Loading

  • optimize setting the parent & the config path on the first run.
    • This fixes having to run the scraper at least twice to setup the parent_id properly.
    • fixes incorrect evaluation of config path
  • Bulk saving of new config items, new config changes & updates to config changes.

@adityathebe adityathebe changed the title Fix/config fix: parent & path of configs & batch saving May 12, 2024
@adityathebe adityathebe marked this pull request as ready for review May 13, 2024 03:39
@adityathebe adityathebe requested a review from moshloop May 13, 2024 03:40
@moshloop moshloop merged commit adf702d into main May 13, 2024
7 checks passed
@moshloop moshloop deleted the fix/config-id branch May 13, 2024 07:53
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.0.267 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshloop moshloop Awaiting requested review from moshloop

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adityathebe @moshloop