feat: azure activity logs #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityathebe
force-pushed
the
feat/azure-activity-log
branch
2 times, most recently
from
16d2204 to
f2140a1
Compare
|
Not sure why there are multiple events for the same action.
|
|
@adityathebe what are we using as the change id ? |
adityathebe
force-pushed
the
feat/azure-activity-log
branch
from
f2140a1 to
7b316a0
Compare
|
|
adityathebe
force-pushed
the
feat/azure-activity-log
branch
from
53bd600 to
9895d6f
Compare
moshloop
reviewed
Dec 5, 2023
moshloop
reviewed
Dec 5, 2023
scrapers/azure/azure.go
Outdated
| // azureActivityExcludeOperations is a list of activity logs we can avoid | ||
| // as they do not mutate any resources. | ||
| var azureActivityExcludeOperations = []string{ | ||
| "Microsoft.ContainerService/managedClusters/listClusterAdminCredential/action", |
There was a problem hiding this comment.
These should probably be exclusions at the crd level
There was a problem hiding this comment.
hmm not sure. I only added these two in particular for debugging reasons but then kept it.
How would end users get the list of operations though? I couldn't find the list.
Still I have implemented this.
There was a problem hiding this comment.
It would normally by seeing lots of changes they are not interested in, and then adding them to the exclusions
moshloop
reviewed
Dec 6, 2023
* aggregate timestamps of the events
adityathebe
force-pushed
the
feat/azure-activity-log
branch
from
a27a851 to
fe47ed7
Compare
|
🎉 This PR is included in version 0.0.154 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #319