Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: embedded db #309

Merged
merged 6 commits into from
Nov 30, 2023
Merged

feat: embedded db #309

merged 6 commits into from
Nov 30, 2023

Conversation

adityathebe
Copy link
Member

resolves: #305

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023 •
edited
Loading

E2E -

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit c87e5b8.

♻️ This comment has been updated with latest results.

@adityathebe adityathebe force-pushed the feat/embedded-db branch 2 times, most recently from e8eea56 to a14c542 Compare November 6, 2023 02:56
@adityathebe adityathebe marked this pull request as ready for review November 6, 2023 02:57
@adityathebe
Copy link
Member Author

adityathebe commented Nov 8, 2023 •
edited
Loading

@moshloop I'm not really sure why we get operation not permitted error when using embedded database. (We try to chmod the dir when setting up embedded db)

  • The Dockerfile correctly has the owner of /opt/database directory set to the new catalog(1000) user. I tested this on a docker container and the permission is correctly set.
  • Inside Kubernetes, since we're mounting a volume to /opt/database, I have also set fsGroup to 1000 in the security context. Can also confirm that the process is run as catalog user.

Despite this, the error still occurs.
Do you see anything obvious that I'm missing?

@adityathebe adityathebe changed the title Feat/embedded db feat: embedded db Nov 8, 2023
@adityathebe
Copy link
Member Author

@moshloop This is ready to go

@adityathebe adityathebe requested a review from moshloop November 8, 2023 13:10
@moshloop moshloop merged commit b13a4df into main Nov 30, 2023
4 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.0.148 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@yashmehrotra yashmehrotra deleted the feat/embedded-db branch December 6, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashmehrotra yashmehrotra Awaiting requested review from yashmehrotra

@moshloop moshloop Awaiting requested review from moshloop

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for embedded database in app and update deployment manifest to run it as a StatefulSet
2 participants
@adityathebe @moshloop