fix: add config data to kubernetes events for post processing #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityathebe
reviewed
Oct 18, 2024
| @@ -241,6 +252,7 @@ func ExtractResults(ctx *KubernetesContext, objs []*unstructured.Unstructured) v | |||
| changeResults = append(changeResults, v1.ScrapeResult{ | |||
| BaseScraper: ctx.config.BaseScraper, | |||
| Changes: []v1.ChangeResult{*change}, | |||
| Config: configData, | |||
There was a problem hiding this comment.
@yashmehrotra why did we add config to changes? we have a config == nil check to distinguish between results that carry config item vs results with only changes.
seeing a lot of errors during extractAttributes because all changes results have an empty ID.
There was a problem hiding this comment.
@adityathebe We have change transformations and exclusions which depend on config being there in cel env
Can you create an issue for the error and assign it to me ? I'll add a check to handle those
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.