fix: chart fixes for upstream #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmehrotra
commented
Oct 9, 2023
pkg/db/init.go
Outdated
| @@ -58,8 +58,7 @@ func embeddedDB() error { | |||
| embeddedPath := strings.TrimSuffix(strings.TrimPrefix(ConnectionString, "embedded://"), "/") | |||
| err := os.Chmod(embeddedPath, 0750) | |||
| if err != nil { | |||
| logger.Errorf("Error changing permission of dataPath: %v, Error: %v", embeddedPath, err) | |||
| return err | |||
| logger.Warnf("Error changing permission of dataPath: %v, Error: %v", embeddedPath, err) | |||
There was a problem hiding this comment.
@moshloop
Not sure why we try to change the mode here. It breaks if we run our current helm chart in embedded mode with default options
Should I change it to warning or just remove the os.Chmod func altogether ?
yashmehrotra
force-pushed
the
chart-update
branch
from
b1cf269
to
a09a4fb
Compare
yashmehrotra
force-pushed
the
chart-update
branch
from
58d99da
to
3a88324
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.