Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only run sync jobs for canaries of specified namespaces #1291

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

adityathebe
Copy link
Member

@adityathebe adityathebe commented Oct 4, 2023

Resolves: #1282

@moshloop moshloop merged commit 03a0d81 into master Oct 4, 2023
11 of 13 checks passed
wwwlde pushed a commit to wwwlde/canary-checker that referenced this pull request Oct 6, 2023
…ource#1291)

* feat: only run sync jobs for canaries of specified namespaces

* chore: fix typo & lint error
@adityathebe adityathebe deleted the fix/operator-namespace branch November 8, 2023 11:52
moshloop added a commit that referenced this pull request Jan 15, 2024
* GitLab Pull-Push checker

* chore: improve metrics troubleshooting

* chore: fix linting errors

* feat: only run sync jobs for canaries of specified namespaces (#1291)

* feat: only run sync jobs for canaries of specified namespaces

* chore: fix typo & lint error

* fix: panic err in counter metric creation

* GitLab Pull-Push checker

* Fixing linter for CRD

* Fixtures for gitProtocol

* Lint issues + Move the creation of the github token into the if statement

* Implement workaround for linters and tests

* Implement workaround for tests

---------

Co-authored-by: Moshe Immerman <[email protected]>
Co-authored-by: Aditya Thebe <[email protected]>
Co-authored-by: Yash Mehrotra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace cli filter does not apply to existing checks
2 participants