feat: Add custom long tap delay #3101
Conversation
| @override | ||
| double get longTapDelay => 0.300; | ||
| int get longTapDelay => _longTapDelay; |
There was a problem hiding this comment.
In Flame we use seconds everywhere, so this should not be changed to milliseconds
| @@ -16,13 +16,18 @@ mixin TapCallbacks on Component { | |||
| void onTapUp(TapUpEvent event) {} | |||
| void onTapCancel(TapCancelEvent event) {} | |||
|
|
|||
| /// The delay (in milliseconds) after which a tap is considered a long tap. | |||
| int get longTapDelay => 300; | |||
There was a problem hiding this comment.
It's a bit strange that it is coming from this mixin, since it'll only have effect the first time a component is added. I think for this case it might be worth adding a static variable to the dispatcher.
There was a problem hiding this comment.
You mean a mutable static? I don't like the ideia. Is there any alternative?
There was a problem hiding this comment.
There are few times where static variables are useful, but since passing this value in from the mixin just makes it more confusing for the user since they'll believe that they can set it per tappable component, I think it is a better option.
However, one downside of it is that it does affect the possibility of having multiple different games in the same app with different long tap delays (a very rare use-case). I don't have any other ideas for how to solve this, if you do, feel free to suggest them.
|
Canceled in favor of #3110 |
Description
Currently
longTapDelayis hardcoded to 300ms.This is good for most of the games. But same games required custom long press values.
This PR allows it.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues