Fix Focus
#623
Merged
Fix Focus
#623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@addie9800 Awesome that you caught these layout edge cases! Regarding the topic part: I wouldn't consider section keywords as useful topics especially since it introduces inconsistency to the actual topic field either for this particular publisher or all publishers as a whole. I would suggest leaving this to downstream tasks like QSE. |
MaxDall
reviewed
Oct 3, 2024
src/fundus/publishers/de/focus.py
Outdated
| _snippet_selector = XPath( | ||
| 'string(//script[@type="text/javascript"][contains(text(), "window.bf__bfa_metadata")])' | ||
| 'string(//script[@type="text/javascript"][contains(text(), "window.bf__bfa_metadata") or contains(text(), "pageAdKeyword")])' |
There was a problem hiding this comment.
Is this still part of the new layout or a leftover of the former topic parsing fallback?
There was a problem hiding this comment.
No, that was also a leftover. It's fixed now
MaxDall
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adresses two issues: