Remove <br> tags in html
#618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDall
requested changes
Sep 30, 2024
Comment on lines
55
to
57
| html = re.sub(r"(<br>)+", "<p>", html) | ||
| doc = lxml.html.document_fromstring(html) | ||
| self.precomputed = Precomputed(html, doc, get_meta_content(doc), get_ld_content(doc)) |
There was a problem hiding this comment.
Two things here:
- The intended way to do something like this would be to use the
functiondecorator instead of overwriting the_base_setup htmlshould still reflect the original HTML. We have to find some way around this.
There was a problem hiding this comment.
I changed it to only modify the html for the purpose of extracting the body. This way it's also not necessary to overwrite the HTML.
MaxDall
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, a
<br>tag is used to start a new paragraph instead of the usual new<p>element. I have modified the_base_setupto replace these tags prior to processing the article. As an extreme example consider this article: https://www.namibian.com.na/namibian-disability-federation-urges-official-recognition-of-sign-language-for-deaf-inclusion/The test case also contains one example.