Add The West Australian #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDall
added
the
DON'T MERGE
MaxDall
removed
the
DON'T MERGE
addie9800
requested changes
Sep 17, 2024
| parser=WestAustralianParser, | ||
| sources=[ | ||
| NewsMap("https://thewest.com.au/news-sitemap.xml"), | ||
| Sitemap("https://thewest.com.au/sitemap.xml", reverse=True), |
There was a problem hiding this comment.
There's also a RSS feed containing the most recent articles: https://thewest.com.au/rss
|
|
||
| @attribute | ||
| def topics(self) -> List[str]: | ||
| return generic_topic_parsing(self.precomputed.ld.bf_search("keywords")) |
There was a problem hiding this comment.
For some reason TheWestAustralian seems to include a lot of duplicate topics. I think we should filter them to be unique (maybe it makes sense to implement it in generic_topic_parsing?). This is already visible in the testcase or in This article. Also, they add the topic premium to their plus articles, I would consider filtering that as well
There was a problem hiding this comment.
Good Point! I will add this in a separate PR
| "string(//script[re:test(text(), 'window.PAGE_DATA')])", | ||
| namespaces={"re": "http://exslt.org/regular-expressions"}, | ||
| ) | ||
| _json_type_pattern = re.compile(r"^(?P<type>.*)=\s*{") |
There was a problem hiding this comment.
This seems to be leftover. At least I couldn't find any usage in the project files.
addie9800
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #614 and should be reviewed afterward.