GH262: Rework URL filter logic [Based on #277] #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDall
added
rework
Merged
dobbersc
reviewed
Aug 29, 2023
dobbersc
removed
the
DON'T MERGE
Co-authored-by: Conrad Dobberstein <[email protected]>
Co-authored-by: Conrad Dobberstein <[email protected]>
# Conflicts: # src/fundus/scraping/html.py # src/fundus/scraping/pipeline.py # src/fundus/scraping/scraper.py
dobbersc
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged after #277
Closes #262
Closes #256