GH-3536: fix state dict key mismatch for embeddings in TextPairRegres… #3537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattGPT-ai
force-pushed
the
fix.text-pair-regressor-state-dict-key-bug
branch
2 times, most recently
from
c216fff
to
22c80a4
Compare
helpmefindaname
force-pushed
the
fix.text-pair-regressor-state-dict-key-bug
branch
from
22c80a4
to
a458f5b
Compare
helpmefindaname
approved these changes
Aug 23, 2024
…irRegressor. this was causing a bug where the model failed to load from the output state dict
helpmefindaname
force-pushed
the
fix.text-pair-regressor-state-dict-key-bug
branch
from
a458f5b
to
d6874a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3536
This simply corrects the state dict name when loading the model from state dict. It is perhaps less ideal to do this than to make the
__init__args consistent with the keys used in_get_state_dictand_init_model_with_state_dict. However, such changes could affect currently saved models or the expected API of Flair, so I went with this safer option.