Use native chrome ssl sockets #433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we relied on a pure javscript ssl implementation called forge for secure sockets. This had a couple of significant downsides: 1. Certificate Authentication via your trusted CA (or any CA) didn't work 2. Name verification wasn't enabled As a result, secure sockets were not secure. This solves the problem by using the (present since Chrome 38) secure socket support. This gives you all of the TLS certificate authentication goodness of chrome for free. As a plus, it's also a relatively simple change, so I was able to delete most of the logic for ssl and just add a separate callback for pre secure connect.
|
As you pointed out I have a similar change https://github.com/flackr/circ/tree/chrome-sockets-tcp-secure. The issue I found when trying this is that chrome.socket requires additional attestation which fails on many SSL irc servers. For example, when connecting to freenode: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks pretty similar to a change by @flackr, but submitting anyway in case there's something I'm missing.
Previously, we relied on a pure javscript ssl implementation called forge
for secure sockets. This had a couple of significant downsides:
As a result, secure sockets were not secure.
This solves the problem by using the (present since Chrome 38) secure
socket support. This gives you all of the TLS certificate authentication
goodness of chrome for free. As a plus, it's also a relatively simple
change, so I was able to delete most of the logic for ssl and just add a
separate callback for pre secure connect.