Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad indentation detection for block collection entries #451

Merged
merged 8 commits into from
Dec 29, 2024

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Dec 29, 2024

This PR fixes detecting bad indentations for block sequence/mapping entries as reported in the issue #449.
Also, the way of managing parse contexts has been improved by separating BLOCK_SEQUENCE_ENTRY from BLOCK_SEQUENCE in the enum class context_state_t for the above fix.
That allows for block sequence entries to be empty and they are now properly parsed.

# The following YAML was parsed as `[foo, [123], bar]` before.
# Now the result is `[foo, [123, null], null, bar]`.
- foo
- - 123
  -
-
- bar

Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the bug Something isn't working label Dec 29, 2024
@fktn-k fktn-k added this to the Release v0.4.1 milestone Dec 29, 2024
@fktn-k fktn-k self-assigned this Dec 29, 2024
Copy link

github-actions bot commented Dec 29, 2024

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 06ae8f2a2d0a5bd6ab8a425ff697c048fcf6b3ef.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr451.zip
ID 2369582001
URL https://github.com/fktn-k/fkYAML/actions/runs/12537281715/artifacts/2369582001

@fktn-k fktn-k changed the title Detect bad indentation for block collection entries Fix bad indentation detection for block collection entries Dec 29, 2024
@fktn-k fktn-k merged commit 08462e2 into develop Dec 29, 2024
162 checks passed
@fktn-k fktn-k deleted the bugfix/449_detect_bad_indentation branch December 29, 2024 17:30
@fktn-k fktn-k mentioned this pull request Dec 29, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant