Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve CMake deprecation warning #442

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

fktn-k
Copy link
Owner

@fktn-k fktn-k commented Dec 13, 2024

Starting with CMake 3.31 (used in the ubuntu-24.04 runner), cmake_minimum_required() emits a warning against the minimum required version begin less than 3.10 like this.
To resolve it, this PR adds a policy_max version for cmake_minimum_required() calls as described in the official document.

Note the same warning is still emitted in the catch2's cmakelists file, where I cannot do anything...


Pull Request Checklist

Read the CONTRIBUTING.md file for detailed information.

  • Changes are described in the pull request or in a referenced issue.
  • The test suite compiles and runs without any error.
  • The code coverage on your branch is 100%.
  • The documentation is updated if you added/changed a feature.

Please don't

  • The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
  • Please refrain from proposing changes that would break YAML specifications. If you propose a conformant extension of YAML to be supported by the library, please motivate this extension.
  • Please do not open pull requests that address multiple issues.

@fktn-k fktn-k added the improvement refactoring or optimization without public API changes label Dec 13, 2024
@fktn-k fktn-k added this to the Release v0.4.1 milestone Dec 13, 2024
@fktn-k fktn-k self-assigned this Dec 13, 2024
Copy link

:octocat: Upload Coverage Event Notification

Coverage data has been uploaded for the commit 281ca6fcb42e3fb6c42fe923b2774bbfa5b010c9.
You can download the artifact which contains the same file uploaded to the Coveralls and its HTML version.

Name fkYAML_coverage.pr442.zip
ID 2317757222
URL https://github.com/fktn-k/fkYAML/actions/runs/12317777259/artifacts/2317757222

@fktn-k fktn-k merged commit 2b8f925 into develop Dec 13, 2024
163 checks passed
@fktn-k fktn-k deleted the fix_cmake_deprecation_warning branch December 13, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement refactoring or optimization without public API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant