Use std::unreachable() or similar compiler specific extensions for dead but necessary code #425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current library deliberately implements some dead codes to suppress warnings against default switch-cases. However, such codes are considered as a possible path from the compiler's view as much frequently as the other "valid" cases.
So, in this PR, such codes have been replaced by calling a function which calls one of the following functions (upper one has more priority) so that a compiler can know the codes are actually unreachable and can be optimized away:
std::unreachable()
(since C++23)__assume(false)
(MSVC)Along with the above change,
FK_YAML_HAS_CXX_23
macro has been added to check if the active C++ standard is 23 or greater. See here for its usage. The library currently has no implementation specific to C++23 features but detection of std::unreachable().Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.
Please don't
#ifdef
s or other means.