-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#133 refactor lexer #146
Merged
Merged
#133 refactor lexer #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fktn-k
added
the
improvement
refactoring or optimization without public API changes
label
Oct 15, 2023
TODOs for myself:
|
I changed implementation to use std::stoxxx() instead of std::strtoxxx() to minimize differences among platforms/compilers in how to handle/express error cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the
lexical_analyzer
class has been refactored by:input_handler
class as a handler of an input adapter,from_string
template functions to generalize conversions from string tokens to native data type values,Furthermore, some small fixes have also been applied such as typos in test case labels or splitting some too complicated functions into somewhat understandably sized ones.
With the changes described above, backward compatibility is still guranteed since previous v0.1 releases.