Feature schema

[lloria91]

adding custom schema validation feature

schema should be compiled Joi schema object.

[codecov]

Codecov Report

Merging #5 into master will decrease coverage by 9.52%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##            master       #5      +/-   ##
===========================================
- Coverage   100.00%   90.47%   -9.53%     
===========================================
  Files            1        1              
  Lines           68       42      -26     
===========================================
- Hits            68       38      -30     
- Misses           0        4       +4     

Impacted Files	Coverage Δ
src/index.js	90.47% <100.00%> (-9.53%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84d9a62...882077c. Read the comment docs.

[fkanout]

@lloria91 I'm was expecting to see a test that covers the use case that we started this implementation in the first place 😄

[lloria91]

@lloria91 I'm was expecting to see a test that covers the use case that we started this implementation in the first place 😄

Test about Complex case is the test no? Schema is almost same as in worker.

[fkanout]

what is the difference between Compiled Joi schema object and Joi schema?

[fkanout]

if it's the same we should keep the terms

[lloria91]

we have simple JS that is transformed to joi.object. Compiled is already Joi object and don't need to call Joi.object function

[lloria91]

they call it compilation of JS object to Joi object on their site

[lloria91]

So what I want to say there is that if you validate query, params and others separately with old version you need to pass JS object. But for schema need to pass Joi object

[fkanout]

If the schema is true, are we still checking the others (headers, query ...etc)?

[lloria91]

check workers APS-38 MR please. schema contains Joi object. In general its already prepared Joi object and in validator no need to call Joi.object function

[fkanout]

Suggested change

	- `schema` - validates all input together, should be used with more complex schemas as [Joi.when](https://hapi.dev/module/joi/api/?v=17.1.1#anywhencondition-options) or [Joi.alternatives](https://hapi.dev/module/joi/api/?v=17.1.1#alternatives).
	- `schema` - validates all input together, should be used with more complex schemas like [Joi.when](https://hapi.dev/module/joi/api/?v=17.1.1#anywhencondition-options) and [Joi.alternatives](https://hapi.dev/module/joi/api/?v=17.1.1#alternatives).

[fkanout]

I don't really understand how the schema is working, roles. e.g.
Add an example with an explanation in the README.

[fkanout]

@lloria91 I'm was expecting to see a test that covers the use case that we started this implementation in the first place 😄

Test about Complex case is the test no? Schema is almost same as in worker.

The worker case is a when not alternative case 🤔

[lloria91]

@lloria91 I'm was expecting to see a test that covers the use case that we started this implementation in the first place 😄

Test about Complex case is the test no? Schema is almost same as in worker.

The worker case is a when not alternative case 🤔

FInally after testing when and alternatives, it is alternative ))