[Console] rename docked console to persistent (elastic#177376)

## Summary Renamed the UI setting for the embedded console from Docked to Persistent per Product's request.
fkanout · Mar 4, 2024 · c7eab2c · c7eab2c
1 parent f634f86
commit c7eab2c
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 14 deletions.
diff --git a/src/plugins/console/public/plugin.ts b/src/plugins/console/public/plugin.ts
@@ -7,7 +7,7 @@
  */
 import { i18n } from '@kbn/i18n';
 import { Plugin, CoreSetup, CoreStart, PluginInitializerContext } from '@kbn/core/public';
-import { ENABLE_DOCKED_CONSOLE_UI_SETTING_ID } from '@kbn/dev-tools-plugin/public';
+import { ENABLE_PERSISTENT_CONSOLE_UI_SETTING_ID } from '@kbn/dev-tools-plugin/public';
 
 import { renderEmbeddableConsole } from './application/containers/embeddable';
 import {
@@ -113,7 +113,7 @@ export class ConsoleUIPlugin implements Plugin<void, void, AppSetupUIPluginDepen
 
     const consoleStart: ConsolePluginStart = {};
     const embeddedConsoleUiSetting = core.uiSettings.get<boolean>(
-      ENABLE_DOCKED_CONSOLE_UI_SETTING_ID
+      ENABLE_PERSISTENT_CONSOLE_UI_SETTING_ID
     );
     const embeddedConsoleAvailable =
       isConsoleUiEnabled &&

diff --git a/src/plugins/dev_tools/common/constants.ts b/src/plugins/dev_tools/common/constants.ts
@@ -11,6 +11,6 @@
  */
 export const DEV_TOOLS_FEATURE_ID = 'devTools';
 /**
- * UI Setting ID for enabling / disabling the docked console in Kibana
+ * UI Setting ID for enabling / disabling the persistent console in Kibana
  */
-export const ENABLE_DOCKED_CONSOLE_UI_SETTING_ID = 'devTools:enableDockedConsole';
+export const ENABLE_PERSISTENT_CONSOLE_UI_SETTING_ID = 'devTools:enablePersistentConsole';
diff --git a/src/plugins/dev_tools/common/index.ts b/src/plugins/dev_tools/common/index.ts
@@ -6,4 +6,7 @@
  * Side Public License, v 1.
  */
 
-export { DEV_TOOLS_FEATURE_ID, ENABLE_DOCKED_CONSOLE_UI_SETTING_ID } from './constants';
+export {
+  DEV_TOOLS_FEATURE_ID,
+  ENABLE_PERSISTENT_CONSOLE_UI_SETTING_ID as ENABLE_DOCKED_CONSOLE_UI_SETTING_ID,
+} from './constants';
diff --git a/src/plugins/dev_tools/server/ui_settings.ts b/src/plugins/dev_tools/server/ui_settings.ts
@@ -10,20 +10,20 @@ import { schema } from '@kbn/config-schema';
 import { UiSettingsParams } from '@kbn/core/types';
 import { i18n } from '@kbn/i18n';
 
-import { DEV_TOOLS_FEATURE_ID, ENABLE_DOCKED_CONSOLE_UI_SETTING_ID } from '../common/constants';
+import { DEV_TOOLS_FEATURE_ID, ENABLE_PERSISTENT_CONSOLE_UI_SETTING_ID } from '../common/constants';
 
 /**
  * uiSettings definitions for Dev Tools
  */
 export const uiSettings: Record<string, UiSettingsParams<boolean>> = {
-  [ENABLE_DOCKED_CONSOLE_UI_SETTING_ID]: {
+  [ENABLE_PERSISTENT_CONSOLE_UI_SETTING_ID]: {
     category: [DEV_TOOLS_FEATURE_ID],
-    description: i18n.translate('devTools.uiSettings.dockedConsole.description', {
+    description: i18n.translate('devTools.uiSettings.persistentConsole.description', {
       defaultMessage:
-        'Docks the Console in the Kibana UI. This setting does not affect the standard Console in Dev Tools.',
+        'Enables a persistent console in the Kibana UI. This setting does not affect the standard Console in Dev Tools.',
     }),
-    name: i18n.translate('devTools.uiSettings.dockedConsole.name', {
-      defaultMessage: 'Docked Console',
+    name: i18n.translate('devTools.uiSettings.persistentConsole.name', {
+      defaultMessage: 'Persistent Console',
     }),
     requiresPageReload: true,
     schema: schema.boolean(),

diff --git a/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts b/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts
@@ -644,7 +644,7 @@ export const stackManagementSchema: MakeSchemaFrom<UsageStats> = {
     type: 'keyword',
     _meta: { description: 'Non-default value of setting.' },
   },
-  'devTools:enableDockedConsole': {
+  'devTools:enablePersistentConsole': {
     type: 'boolean',
     _meta: { description: 'Non-default value of setting.' },
   },

diff --git a/src/plugins/kibana_usage_collection/server/collectors/management/types.ts b/src/plugins/kibana_usage_collection/server/collectors/management/types.ts
@@ -170,5 +170,5 @@ export interface UsageStats {
   'observability:profilingAzureCostDiscountRate': number;
   'data_views:fields_excluded_data_tiers': string;
   'observability:apmEnableTransactionProfiling': boolean;
-  'devTools:enableDockedConsole': boolean;
+  'devTools:enablePersistentConsole': boolean;
 }
diff --git a/src/plugins/telemetry/schema/oss_plugins.json b/src/plugins/telemetry/schema/oss_plugins.json
@@ -10282,7 +10282,7 @@
             "description": "Non-default value of setting."
           }
         },
-        "devTools:enableDockedConsole": {
+        "devTools:enablePersistentConsole": {
           "type": "boolean",
           "_meta": {
             "description": "Non-default value of setting."