Skip to content

Commit

Permalink
Use correct labels and i18n in where item component
Browse files Browse the repository at this point in the history
  • Loading branch information
askask committed Aug 26, 2024
1 parent d384175 commit 32300e7
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
</div>

<mat-form-field appearance="outline" class="input num-tiny-input operator-select">
<mat-label id="label">Operator</mat-label>
<mat-label>{{ 'LOGICAL_OPERATOR' | translate }}</mat-label>
<mat-select
[attr.aria-label]="'LOGICAL_OPERATOR' | translate"
[(value)]="item.comparisonOperator"
Expand All @@ -27,9 +27,9 @@
class="input num-tiny-input value-input"
*ngIf="item.isParameterType"
>
<mat-label id="label">Parametername</mat-label>
<mat-label id="label">{{ 'PARAMETER_NAME' | translate }}</mat-label>
<input
aria-labelledby="label"
[attr.aria-label]="'PARAMETER_NAME' | translate"
type="text"
matInput
formControlName="value"
Expand All @@ -51,9 +51,9 @@
class="num-tiny-input parameter-select"
*ngIf="dialogMode === aqlBuilderDialogMode.AqlEditor"
>
<mat-label id="label">Parameter</mat-label>
<mat-label>{{ 'PARAMETER' | translate }}</mat-label>
<mat-select
[attr.aria-label]="'LOGICAL_OPERATOR' | translate"
[attr.aria-label]="'PARAMETER' | translate"
[(value)]="item.isParameterType"
data-test="aqb__where__item__is-parameter__selector"
>
Expand Down
4 changes: 3 additions & 1 deletion src/assets/i18n/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,9 @@
"SELECT_A_EHR_TEMPLATE": "Bitte wählen Sie mindestens 1 Rückgabeparameter",
"MAIN_GROUP": "Hauptgruppe",
"SUB_GROUP": "Untergruppe",
"LOGICAL_OPERATOR": "Logischer Operator",
"LOGICAL_OPERATOR": "Operator",
"PARAMETER": "Parameter",
"PARAMETER_NAME": "Parametername",
"COMMENTS": "Kommentare",
"WRITE_COMMENT": "Kommentar schreiben",
"LEAVE_COMMENT": "Hinterlassen Sie hier einen Kommentar, um Ihre Gedanken mitzuteilen",
Expand Down
4 changes: 3 additions & 1 deletion src/assets/i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,9 @@
"SELECT_A_EHR_TEMPLATE": "Please select at least 1 Return Parameter",
"MAIN_GROUP": "Maingroup",
"SUB_GROUP": "Subgroup",
"LOGICAL_OPERATOR": "Logical operator",
"LOGICAL_OPERATOR": "Operator",
"PARAMETER": "Parameter",
"PARAMETER_NAME": "Parameter name",
"COMMENTS": "Comments",
"WRITE_COMMENT": "Write comment",
"LEAVE_COMMENT": "Leave a comment here to share your thoughts",
Expand Down

0 comments on commit 32300e7

Please sign in to comment.