feat: add an hasSize function

[alberic89]

No description provided.

[fjebaker]

Suggested change

	// Check is there is enough memory allocated
	// Check if buffers have sufficient memory for a given haystack and
	// needle length.

[fjebaker]

Suggested change

	if (self.max_haystack < max_haystack or self.max_needle < max_needle) {
	return false;
	} else {
	return true;
	}
	return (max_haystack <= self.max_haystack) and (max_needle <= self.max_needle);

It's easier just to check the positive case.

[fjebaker]

Suggested change

	pub fn hasSize(self: *Self, max_haystack: usize, max_needle: usize) bool {
	pub fn hasSize(self: *const Self, max_haystack: usize, max_needle: usize) bool {

This won't and should not mutate memory, so we mark the pointer as const.

[fjebaker]

Suggested change

	// Check is there is enough memory allocated
	pub fn hasSize(self: *Ascii, max_haystack: usize, max_needle: usize) bool {
	// Check if buffers have sufficient memory for a given haystack and
	// needle length.
	pub fn hasSize(self: *const Ascii, max_haystack: usize, max_needle: usize) bool {

[fjebaker]

Suggested change

	// Check is there is enough memory allocated
	pub fn hasSize(self: *Unicode, max_haystack: usize, max_needle: usize) bool {
	// Check if buffers have sufficient memory for a given haystack and
	// needle length.
	pub fn hasSize(self: *const Unicode, max_haystack: usize, max_needle: usize) bool {

[fjebaker]

In your previous PR you had some tests that made sure resize works. It would be very useful to include those (and similar for hasSize) in this PR too 👍

[alberic89]

But just a question : is it an error that there is < and not <= at

fuzzig/src/root.zig

Line 256 in 2c5d606

std.debug.assert(needle.len < self.maximumNeedleLen());

?
It makes score fail when there is just the size needed.

[fjebaker]

is it an error that there is < and not <= at

Yes that is a mistake. Well spotted! Make sure there's a test that catches it and then I think this will be ready to merge.

Edit: I see you're ahead of me and already have!

[fjebaker]

This is all great! My only suggestion is to add a handful more tests that check that smaller sizes pass, and that larger sizes do indeed fail (even after resize).

When you're happy, let me know and we can merge.

[alberic89]

For me, all is good. We can merge it.