Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(tester): add details for trunacte destination operation in the development guide #83

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shivangisingh172
Copy link
Contributor

Copy link

height bot commented Jan 15, 2025

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@@ -148,6 +148,7 @@ The `DescribeTable` RPC call should report all columns in the destination table,
#### Truncate
- The `Truncate` RPC call might be requested for a table that does not exist in the destination. In that case, it should NOT fail, simply ignore the request and return `success = true`.
- `utc_delete_before` has millisecond precision.
- `soft` indicates that the truncate operation is a soft truncate operation and instead of removing the rows the specified `delete_column` needs to be marked as true.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `soft` indicates that the truncate operation is a soft truncate operation and instead of removing the rows the specified `delete_column` needs to be marked as true.
- `soft` indicates that the `truncate` operation is a soft truncate operation and instead of removing the rows, the specified `delete_column` needs to be marked as `true`.

Is the actual column name delete_column?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants