Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(tester): add pre requisite info #77

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Conversation

shivangisingh172
Copy link
Contributor

@shivangisingh172 shivangisingh172 commented Nov 22, 2024

links: T-815728
Closes T-840533
The destination setup requires a base account level to facilitate seamless processing of data. This needs to be added in the docs. Added the guideline in the documentation guide.

@shivangisingh172 shivangisingh172 self-assigned this Nov 22, 2024
Copy link

height bot commented Nov 22, 2024

This pull request has been linked to and will mark 1 task as "Done" when merged:

💡Tip: You can link multiple Height tasks to a pull request.

@shivangisingh172
Copy link
Contributor Author

@5tran-alexil We also want to add that if the sync fails due to account level limitations the partners must throw a warning. But I'm not sure how and where to add it. Could you please recommend where can I add this information?

@5tran-alexil
Copy link
Contributor

@fivetran-backend create demo

@5tran-alexil
Copy link
Contributor

@5tran-alexil We also want to add that if the sync fails due to account level limitations the partners must throw a warning. But I'm not sure how and where to add it. Could you please recommend where can I add this information?

This must be described in the technical details first, how it needs/is recommended to be implemented, as logs, dashboard errors etc. We can then link from the requirements to that description.

@5tran-alexil
Copy link
Contributor

@fivetran-backend create demo

@5tran-alexil
Copy link
Contributor

@shivangisingh172 The technical details and requirement for the destination to throw a clear error when the account permissions are not sufficient to create the destination belong to https://github.com/fivetran/fivetran_sdk/blob/main/development-guide.md

@shivangisingh172
Copy link
Contributor Author

@5tran-alexil Updated the dev guide, please review the change.

Copy link
Contributor

@5tran-alexil 5tran-alexil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@shivangisingh172 shivangisingh172 merged commit 37c42f4 into main Nov 29, 2024
1 check failed
@shivangisingh172 shivangisingh172 deleted the update-dest-setup-guide branch November 29, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants