fix(Logging): Add examples for providing logs #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-satvikpatil
requested review from
manjutapali and
fivetran-rishabhghosh
|
Other changes look good |
manjutapali
approved these changes
Oct 29, 2024
| @@ -112,4 +117,8 @@ public void writeBatch(WriteBatchRequest request, StreamObserver<WriteBatchRespo | |||
| responseObserver.onNext(WriteBatchResponse.newBuilder().setSuccess(true).build()); | |||
| responseObserver.onCompleted(); | |||
| } | |||
|
|
|||
| private void print(String level, String message){ | |||
There was a problem hiding this comment.
NIT: rename logMessage
There was a problem hiding this comment.
Updated it
added 2 commits
October 29, 2024 16:19
fivetran-rishabhghosh
approved these changes
Oct 29, 2024
added 2 commits
October 30, 2024 14:37
|
Created a follow-up ticket to improve golang example: https://fivetran.height.app/T-822463 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
T-818866
Description
Added example for providing logs via std::out stream
Testing
Source Connector
Destination Connector