Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fivetran_sdk): Update guide to not consider backslash as escape char #37

Merged
merged 1 commit into from
May 13, 2024

Conversation

fivetran-abdulsalam
Copy link
Contributor

We create CSV split file as:

CsvSchema.Builder builder = CsvSchema.builder();
for (Column c : finalColumns) builder.addColumn(c.name, csvType(c.type));
CsvSchema csvSchema = builder.setUseHeader(true).setNullValue(DataWriter.WAREHOUSE_NULL).build();
CSV.configure(JsonGenerator.Feature.FLUSH_PASSED_TO_STREAM, false);

And by Default in CSVSchema no escape character is used and thus we can create spit file as:

id,val,name,_fivetran_synced
1,"abc , \",abdul,2024-05-09T10:22:59.588Z
2,"abcd ",salam,2024-05-09T10:22:59.621Z

Updated development guide indicating this so partner do not consider backslash as escape character.

@fivetran-abdulsalam fivetran-abdulsalam merged commit 2425f72 into main May 13, 2024
1 check passed
@fivetran-abdulsalam fivetran-abdulsalam deleted the update-guide-escape-char branch May 13, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants