Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add passthrough columns for USER + ORG and add support for updated passthrough format for TICKET #49

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Apr 5, 2024

PR Overview

This PR will address the following Issue/Feature:
fivetran/dbt_zendesk#122 --> will need to update transform README after this

This PR will result in the following new package version:

v0.11.2

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Feature Updates

  • Adds passthrough column support for USER and ORGANIZATION.
    • Using the new zendesk__user_passthrough_columns and zendesk__organizations_passthrough_columns variables, you can include custom columns from these source tables in their respective staging models. See README for more details on how to configure.
  • Also updated the format of the pre-existing TICKET passthrough column variable, zendesk__ticket_passthrough_columns.
    • Previously, you could only provide a list of custom fields to be included in stg_zendesk__ticket. Now, you can provide an alias and transform_sql clause to be applied to each field (see README for more details).
    • Note: the package is and will continue to be backwards compatible with the old list-format.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates) -- will regen after approval
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

First, I ran with the new format across the board:
image

Everything passed

  • dbt run
image
  • dbt test
image

And I verified that the custom columns were present, filled with data, and properly aliased (if provided) in the WH

TICKET
image

USER
image

ORGANIZATION
image

I then reran, with

  • zendesk__ticket_passthrough_columns using the old, currently employed format
  • no values for the user and organization passthrough columns (just want to confirm these compile correctly)
image

Everything passed

  • dbt run
image
  • dbt test
image

In the WH, I confirmed that the staging ticket model had the custom columns, even if using the old variable format, which our macros are backwards compatible with
image

If you had to summarize this PR in an emoji, which would it be?

🛃

@fivetran-jamie fivetran-jamie self-assigned this Apr 5, 2024
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie these changes look good to me! Would you also be able to open a proactive FR on the transform package to allow us to expand the passthrough columns for User and Organization downstream as well.

Be sure to regen the docs, then this is good to go!

@fivetran-jamie fivetran-jamie merged commit 92b0923 into main Apr 15, 2024
7 checks passed
fivetran-jamie added a commit that referenced this pull request Jun 24, 2024
* Add passthrough columns for USER + ORG and add support for updated passthrough format for TICKET (#49)

* add passthrough columns for user + org and revamp ticket passthru var

* add default value

* docs

* doc twweaks

* add followup_ids

* add followup_ids

* revert

* docs

* seed

* bk
fivetran-jamie added a commit that referenced this pull request Jun 24, 2024
* Add passthrough columns for USER + ORG and add support for updated passthrough format for TICKET (#49)

* add passthrough columns for user + org and revamp ticket passthru var

* add default value

* docs

* doc twweaks

* add followup_ids

* add followup_ids

* revert

* docs

* seed

* bk

* does that fix things

* use diff version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants