Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ticket schedule from qs file #143

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

fivetran-reneeli
Copy link
Contributor

PR Overview

This PR will address the following Issue/Feature:
For Quickstart transformations we have removed the ticket_schedule requirement. As such we need to remove it from the config in our quickstart.yml, otherwise customers who don't have the ticket_schedule table will not see certain end objects populating.

This PR will result in the following new package version:

na

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Bug Fix

na

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • [na] The appropriate issue has been linked, tagged, and properly assigned
  • [na] All necessary documentation and version upgrades have been applied
  • [na] docs were regenerated (unless this PR does not include any code or yml updates)
  • [na] BuildKite integration tests are passing
  • [ na] Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

This will be validated by seeing the relevant end objects such as the first_reply_time_business_minutes metric populate

If you had to summarize this PR in an emoji, which would it be?

💃

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fivetran-reneeli fivetran-reneeli merged commit 4faf043 into main Feb 8, 2024
8 checks passed
@fivetran-reneeli fivetran-reneeli deleted the bugfix/remove_ticket_schedule_from_qs branch February 8, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants