Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce the hubspot engagement table to adjust the joins in int_hub… #13
base: main
Are you sure you want to change the base?
introduce the hubspot engagement table to adjust the joins in int_hub… #13
Changes from 14 commits
c3218b4
5b7920a
51a7484
ed1e205
2db9b0a
57a1017
0829812
938807b
b175bfe
f846b71
c8cd90a
ea23ba5
588d324
dda981c
2768c4d
e484cfd
528f43c
67cb540
67dff0d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason only a subset of seed columns are being run and tested here? Can we add all the relevant columns brought into the staging model?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a great point. i initially mocked this up from the internal schema with the new version of tables that i was testing with. I added in the rest of the columns!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I realized that now that
engagement
exists and the fieldengagement_type
is available in that table, do we still need the coalesce between"engagement_emails.engagement_type", "engagement_notes.engagement_type"
heredbt_unified_rag/models/intermediate/hubspot/int_rag_hubspot__deal_document.sql
Line 56 in 96524a7
in order to grab
engagement_type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update-- have since removed the previous
"engagement_emails.engagement_type", "engagement_notes.engagement_type"
to swap withengagement.engagement_type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to document
source_relation
!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! updated